This content originally appeared on DEV Community and was authored by Ahmad
Part of Release 0.1 was to make a meaningful contribution to either telescope or the modernization of IPC144 project. I went with the latter.
The Issue
I scrolled through the list of issues to get an idea of what's being worked on. I noticed a large issue that requested an audit of all markdown pages.
I chose a random markdown page from the list and created my own issue stating that I'd like to work on it.
I quickly noticed a lot of small problems with the page. Such as missing alt texts, extra code block indentations, missing backticks, and images not being centered.
For the image centering, I wanted to use the text-align CSS property. This property only works in div tags, so I changed the .mdImg CSS class to div.mdImg. Because .mdImg was being used on another markdown page, I had to change the span elements to div on that page.
Pull Request
Once I was done auditing I submitted a pull request and waited. A day later it was explained to me that we'd soon be using the ideal-image plugin to handle all of the image stuff, so my changes weren't needed. I was told we could keep my changes for now, and replace them with ideal-image whenever it's implemented. This made sense and the pull request was merged.
This content originally appeared on DEV Community and was authored by Ahmad
Ahmad | Sciencx (2021-11-18T18:14:43+00:00) Internal PR for Release 0.3. Retrieved from https://www.scien.cx/2021/11/18/internal-pr-for-release-0-3/
Please log in to upload a file.
There are no updates yet.
Click the Upload button above to add an update.